[openal] Making functions noexcept

[James Turner]

> On 19 May 2023, at 08:39, Chris Robinson <chris.kcat at gmail.com> wrote:
> 
> There is, however, a small potential for API incompatibility, which is causing me some hesitation. ABI is fine, apps and binaries built using non-noexcept headers will still work without issue at runtime, but some C++ code made for non-noexcept headers could potentially have issues (re)compiling with updated noexcept headers. In particular, if the code had defined its own AL-like fallback functions or callbacks without noexcept, and tries to set them on function pointers with noexcept typedefs. The compiler won't like that since it'll see a potentially-throwing function set on a function pointer that's not allowed to throw when called. This can be fixed by the app adding noexcept to their fallback/callback functions, which they really should be anyway. And more generally, code written with the updated noexcept headers in mind will still work with non-noexcept headers.
> 
> 
> So I'm looking for feedback. Making the functions and function pointer types noexcept for C++ would be beneficial, existing binaries would have no issues, and there's only a small possibility for fixable compile issues in existing code. But given that there can be issues, however minor, I wanted to get others' opinions before doing anything.

Make the noexcept stuff (which I think is excellent to add) in some macros controlled by a define which can be set before including al.h? 

Default to noexcept, but if someone sets OPENALSOFT_ENABLE_NOEXCEPT to 0, then have some macros which evaluate to empty?

A bit ugly, as will all preprocessor tricks, of course.

Kind regards,
James


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://openal.org/pipermail/openal/attachments/20230519/d5d85f42/attachment.htm>